Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox placeholder text is faded out and not the full color. #11526

Merged
merged 1 commit into from Nov 18, 2013

Conversation

erikflowers
Copy link

  • Adding opacity:1 to it returns it to the proper color
  • (this is a re-commit since I messed up my branch last time and failed the travis build)

My previous pull request I did wrong as I didn't make a new branch (first time doing that). This should not fail the build and make everything work properly. Sorry.

…g opacity:1 to it returns it to the proper color

- (this is a re-commit since I messed up my branch last time and failed the travis build)
@cvrebert
Copy link
Collaborator

Testcase: http://jsfiddle.net/8b2d6/2/
Confirmed that this auto-dimming behavior doesn't match Chrome.

mdo added a commit that referenced this pull request Nov 18, 2013
Firefox placeholder text is faded out and not the full color.
@mdo mdo merged commit 7c9b932 into twbs:master Nov 18, 2013
@mdo
Copy link
Member

mdo commented Nov 18, 2013

<3 Thanks!

@erikflowers
Copy link
Author

Feels good man.

@erikflowers erikflowers deleted the firefox-placeholder-fix branch November 18, 2013 21:48
@cvrebert
Copy link
Collaborator

X-Ref: necolas/normalize.css#246

cvrebert added a commit that referenced this pull request Nov 18, 2013
@FatBoyXPC
Copy link

Should this be added for firefox 4-18, too? I don't have 4-18 installed anywhere (nor am I really too worried people will be on FF4-18). Just seems like it'd make sense for consistency, though.

@erikflowers
Copy link
Author

I'm happy to test if I can wrangle up a version. I'll see what I can scour.

@cvrebert
Copy link
Collaborator

More precise X-Ref: necolas/normalize.css#263

@cvrebert
Copy link
Collaborator

stempler pushed a commit to stempler/bootstrap that referenced this pull request Nov 4, 2014
cvrebert added a commit that referenced this pull request Dec 23, 2014
[skip sauce]
[skip validator]
silverbackdan added a commit to silverbackdan/bootstrap that referenced this pull request May 24, 2017
When using form-control-lg or form-control-sm some css properties of form-control are not respected as when using form-control:
- placeholder style
- disabled style

I'm not sure if the form-control-ficus mixin may have been missing too...

This would also require the addition to _form.scss in the mixins:
```scss
@mixin form-control-states() {
  // Placeholder
  &::placeholder {
    color: $input-color-placeholder;
    // Override Firefox's unusual default opacity; see twbs#11526.
    opacity: 1;
  }

  // Disabled and read-only inputs
  //
  // HTML5 says that controls under a fieldset > legend:first-child won't be
  // disabled if the fieldset is disabled. Due to implementation difficulty, we
  // don't honor that edge case; we style them as disabled anyway.
  &:disabled,
  &[readonly] {
    background-color: $input-bg-disabled;
    // iOS fix for unreadable disabled content; see twbs#11655.
    opacity: 1;
  }
}
```
@y377
Copy link

y377 commented Nov 27, 2022

.../stylesheets/bootstrap/forms/_form-control.scss
This value should be removedopacity: 1;. The default color in firefox is too black

> firefox 107.0 Firefox Release November 15, 2022

Before modification

.form-control::placeholder {
color: #6c757d;
opacity: 1; 
}

image

After repair

  &::placeholder {
    color: $input-placeholder-color;
    // Override Firefox's unusual default opacity; see https://github.com/twbs/bootstrap/pull/11526.
    // opacity: 1;
  }

image

&:disabled {
    color: $input-disabled-color;
    background-color: $input-disabled-bg;
    border-color: $input-disabled-border-color;
    // iOS fix for unreadable disabled content; see https://github.com/twbs/bootstrap/issues/11655.
    opacity: 1;
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants